Conversation
|
The problem is actually with nodegit and that we were relying on a bug to get our stuff to work instead of using the built in functionality of promisify. So in the old version of promisify, if you pass in just a function it would promisify it even if it didn't fulfill the internal criteria for promisification (Is that a word???) So now I just had to change some nodegit code to get it to work. So in the next release of nodegit we can use the newest and latest and greatest version of promisify. But we can't merge this in and re-publish promisify until nodegit gets a version bump. |
|
Should I merge this? |
|
I think so. We should do a version bump of this library as well. I don't want something unexpectedly breaking in nodegit. |
|
I'm merging this and then I'll update nodegit accordingly. We should major version bump since I had to change to the latest nodegit-promise as well. |
Undo revert of refactored code
|
So we'll need better tests for this library. Apparently this is breaking a lot of stuff not even related to nodegit. I'm reverting this for now. |
No description provided.